-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: support development releases of Python #3419
Conversation
2abb0d4
to
ee1fb1b
Compare
@henryiii I think the crash might be related to calling the CPython APIs in get_type_override when being dispatched from a PURE_OVERRIDE call, specifically here: pybind11/tests/test_factory_constructors.cpp Line 123 in 6abf2ba
|
for more information, see https://pre-commit.ci
…pybind11 into henryiii/ci/python-dev
Could you do that? You've looked into it the most. |
If you want, we could just disable the two failing tests on PyPy and move forward with PyPy testing. The garbage collector one doesn't clean up, even on 3.7, and the hook one doesn't work for mysterious reasons (I can't make a MWE, it seems to work in MWE form). |
cee0419
to
0618bd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
standard: | ||
name: "🐍 3.11 dev • ubuntu-latest • x64" | ||
runs-on: ubuntu-latest | ||
if: "contains(github.event.pull_request.labels.*.name, 'python dev')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will trigger for workflow dispatch. And I wanted it to run weekly. Can do in a followup PR.
Description
Suggested changelog entry:
* Test python-3.11 on PRs with the ``python dev`` label. * Support PyPy 7.3.7 and the PyPy3.8 beta.